important fixes for new and running systems

[distro-setup] / distro-end

diff --git a/distro-end b/distro-end
index 655ae7f4c19d68bf6f4aa1cb6c9ea25997f03b3b..c22e1130be39b67136dd60c5581f0776c1674771 100755 (executable)
--- a/distro-end
+++ b/distro-end
@@ -114,7 +114,7 @@ if isdeb; then
   l="deb [arch=amd64] $url $(debian-codename-compat) stable"
 
   if ! grep -xFq "$l" /etc/apt/sources.list{,.d/*.list}; then
-    sudo add-apt-repository $l
+    sudo add-apt-repository "$l"
     p update
   fi
   # docker eats up a fair amount of cpu when doing nothing, so don't enable it unless
@@ -604,8 +604,8 @@ deb [arch=amd64] https://downloads.iridiumbrowser.de/deb/ stable main
 EOF
     f=/etc/apt/sources.list.d/iridium-browser.list
     if ! diff -q $t $f; then
-      cp $t $f
-      chmod 644 $f
+      s cp $t $f
+      s chmod 644 $f
       p update
     fi
     pi iridium-browser
@@ -970,8 +970,8 @@ deb http://us.archive.ubuntu.com/ubuntu/ bionic-security main
 EOF
     f=/etc/apt/sources.list.d/bionic.list
     if ! diff -q $t $f; then
-      cp $t $f
-      chmod 644 $f
+      s cp $t $f
+      s chmod 644 $f
       p update
     fi
 
@@ -1089,9 +1089,9 @@ esac
 # 450 seems likely to be unused. we need to specify one or else
 # it won't be stable across installs.
 if ! getent passwd debian-transmission > /dev/null; then
+  s groupadd -g 450 debian-transmission
   case $distro in
     arch)
-      s groupadd -g 450 debian-transmission
       s useradd \
         --system \
         --create-home \
@@ -1106,7 +1106,6 @@ if ! getent passwd debian-transmission > /dev/null; then
         --gid 450 \
         --uid 450 \
         --system \
-        --group \
         --no-create-home \
         --disabled-password \
         --home /var/lib/transmission-daemon \
@@ -1339,7 +1338,7 @@ case $distro in
       # just the latest stable at the time of writing
       # TODO, maybe put this all into a build script,
       # and do some automatic updates
-      wget https://dl.google.com/go/go1.12.4.linux-amd64.tar.gz
+      wget -q https://dl.google.com/go/go1.12.4.linux-amd64.tar.gz
       s tar -C /usr/local -xzf go1.12.4.linux-amd64.tar.gz
       rm -f *
     fi