misc minor fixes

[distro-setup] / brc

diff --git a/brc b/brc
index b0f8846bef148f95392839e8e32808ef66893b54..c9cd4fcee4af66f81029ec406f6007de50d9ae0a 100644 (file)
--- a/brc
+++ b/brc
@@ -1689,23 +1689,15 @@ sgu() {
 sk() {
 
 
-  # note, if you do something like this
-  # x=( prefix* )
-  # then disable the warning with:
-  # shellcheck disable=SC2206 # globbing is intended
+  # disable a warning with:
+  # shellcheck disable=SC2206 # reasoning
 
-  # 2029: "unescaped, this expands on the client side.": yes, I know how ssh works
-  # 2164: "Use 'cd ... || exit' or 'cd ... || return' in case cd fails.": i have automatic error handling
-  # 2086: unquoted $var: Quoting every var I set is way too much quotes.
-  # 2068: Double quote array expansions to avoid re-splitting elements: same as above.
-  # 2033: command arg is a function name: too many false positives.
+  # see bash-template/style-guide.md for justifications
 
-
-  # these ones I had disabled, but without a good written explanation, so enabling them temporarily
-  # 2046: unquoted $(cmd)
-  # 2119: Functions with optional args get bad warnings when none are passed.
-
-  shellcheck -W 999 -x -e 2029,2164,2086,2068,2033 "$@" || return $?
+  local quotes others
+  quotes=2048,2068,2086,2206
+  others=2029,2033,2164
+  shellcheck -W 999 -x -e $quotes,$others "$@" || return $?
 }