lots: shellcheck, streaming stuff, fixes

[distro-setup] / brc

diff --git a/brc b/brc
index 2a81b25fa369f557d373f431d3c56400f61e9707..f0b57f8cc1558918fdd34ff410da566854024207 100644 (file)
--- a/brc
+++ b/brc
@@ -347,6 +347,9 @@ if [[ $SOE ]]; then
   fi
 fi
 
+# go exists here
+path-add --ifexists /usr/local/go/bin
+
 
 mysrc() {
   local path dir file
@@ -870,9 +873,21 @@ khfix() {
 a() {
   local x
   x=$(readlink -nf "${1:-$PWD}")
-  # yes, its kinda dumb that xclip/xsel cant do this in one invocation
-  echo -n "$x" | xclip -selection clipboard
-  echo -n "$x" | xclip
+  # yes, its kinda dumb that xclip/xsel cant do this in one invocation.
+  # And, summarizing this:
+  # https://askubuntu.com/questions/705620/xclip-vs-xsel
+  # xclip has a few more options. xclip has a bug in tmux / forwarded x sessions.
+  cbs "$x"
+}
+
+# clipboard a string (into selection & clipboard buffer)
+cbs() {
+  # yes, its kinda dumb that xclip/xsel cant do this in one invocation.
+  # And, summarizing this:
+  # https://askubuntu.com/questions/705620/xclip-vs-xsel
+  # xclip has a few more options. xclip has a bug in tmux / forwarded x sessions.
+  printf "%s" "$*" | xclip -selection clipboard
+  printf "%s" "$*" | xclip
 }
 
 # a1 = awk {print $1}
@@ -1609,8 +1624,9 @@ gl() {
   "$@" &> /a/tmp/gtmp
   g /a/tmp/gtmp
 }
-# g command substitution
+# g command substitution.
 gc() {
+  # shellcheck disable=SC2046 # i want word splitting for this hackery
   g $("$@")
 }
 
@@ -1720,7 +1736,7 @@ go-github-install() {
   file_prefix=$2
   file_suffix=$3
   tmp="${file_prefix##*[[:alnum:]]}"
-  targetf="${file_prefix%$tmp}"
+  targetf="${file_prefix%"$tmp"}"
   echo targetf: $targetf
   github-release-dl "$@"
   files=(./*)
@@ -2429,15 +2445,16 @@ sgu() {
 
 
 sk() {
-  # disable a warning with:
-  # shellcheck disable=SC2206 # reasoning
-
-  # see bash-template/style-guide.md for justifications
-
-  local quotes others
+  # see https://savannah.gnu.org/maintenance/fsf/bash-style-guide/ for justifications
+  local quotes others ret
   quotes=2048,2068,2086,2206,2254
   others=2029,2032,2033,2054,2164,
-  shellcheck -W 999 -x -e $quotes,$others "$@" || return $?
+  shellcheck -W 999 -x -e $quotes,$others "$@" || ret=$?
+  if (( ret >= 1 )); then
+    echo "A template comment to disable is now in clipboard. eg: # shellcheck disable=SC2206 # reason"
+    cbs "# shellcheck disable=SC"
+    return $ret
+  fi
 }
 # sk with quotes. For checking scripts that we expect to take untrusted
 # input in order to verify we quoted vars.
@@ -2823,7 +2840,7 @@ psoff() {
 pson() {
   PROMPT_COMMAND=(prompt-command)
   if [[ $TERM == *(screen*|xterm*|rxvt*) ]]; then
-    trap 'settitle "$BASH_COMMAND"' DEBUG
+    trap 'auto-window-title "$BASH_COMMAND"' DEBUG
   fi
 }
 
@@ -3125,6 +3142,12 @@ EOF
   done
 }
 
+# note, there is also the tool gron which is meant for this, but
+# this is good enough to not bother installing another tool
+jq-lines() {
+  # https://stackoverflow.com/questions/59700329/how-to-print-path-and-key-values-of-json-file-using-jq
+  jq --stream -r 'select(.[1]|scalars!=null) | "\(.[0]|join(".")): \(.[1]|tojson)"' "$@"
+}
 
 tsr() { # ts run
   "$@" |& ts || return $?
@@ -3284,7 +3307,7 @@ if [[ $- == *i* ]]; then
   fi
 
   # make the titlebar be the last command and the current directory.
-  settitle () {
+  auto-window-title () {
 
 
     # These are some checks to help ensure we dont set the title at
@@ -3309,7 +3332,7 @@ if [[ $- == *i* ]]; then
   # condition from the screen man page i think.
   # note: duplicated in tx()
   if [[ $TERM == *(screen*|xterm*|rxvt*) ]]; then
-    trap 'settitle "$BASH_COMMAND"' DEBUG
+    trap 'auto-window-title "$BASH_COMMAND"' DEBUG
   else
     trap DEBUG
   fi