lots: shellcheck, streaming stuff, fixes

[distro-setup] / check-stale-alerts

diff --git a/check-stale-alerts b/check-stale-alerts
index 1ecb58bf761aed1cacb9140ac845792d03c46163..cd42122f0791f727b6a11a195502e3c22fb3ed4a 100755 (executable)
--- a/check-stale-alerts
+++ b/check-stale-alerts
@@ -4,9 +4,17 @@
 if [[ ! -e /dev/shm/iank-status ]]; then
   exit 0
 fi
-eval $(< /dev/shm/iank-status)
+eval "$(< /dev/shm/iank-status)"
 
-out=$(find /var/local/cron-errors /home/iank/cron-errors /sysd-mail-once-state -type f)
+dirs=()
+for d in /var/local/cron-errors /home/iank/cron-errors /sysd-mail-once-state; do
+  if [[ -e $d ]]; then
+    dirs+=($d)
+  fi
+done
+if (( ${#dirs[@]} >= 1 )); then
+  out=$(find ${dirs[@]} -type f)
+fi
 if [[ $out ]]; then
   echo HOSTNAME: $HOSTNAME
   printf "%s\n" "$out"
@@ -21,3 +29,8 @@ for h in {li,bk,je}.b8.nz; do
     printf "%s\n" "$out"
   fi
 done
+
+# for .prom.$PID files, they will naturally exist when
+# scripts like system-status get killed on reboot.
+# Just clean them up here.
+find /var/lib/prometheus/node-exporter -name '*[0-9]' -type f -mtime 9 -delete